bustikiller/wedding-planner
1
0
Fork 0
Code Issues Pull Requests 4 Actions Packages Projects Releases Wiki Activity

Use group affinities in discomfort calculator #215

Merged
bustikiller merged 1 commits from discomfort-calculation-revamp into main 2025-01-19 20:19:10 +00:00
Conversation 0 Commits 1 Files Changed 5 +43 -177
bustikiller commented 2025-01-19 19:59:50 +00:00
Owner
Copy Link

Why

We've recently included the concept of group affinities, which allows users specify the affinity between groups for the seating distribution. However, these values were not used thus far.

In this PR, we're modifying the calculator to take these values into account, instead of the previous distance-based affinity.

We're also making the AffinityGroupsHierarchy not a singleton anymore, as that doesn't quite fit a multi-tenant system. Additionally, memoized variables would never be removed by the GC, leading to a memory leak at some point.

## Why We've recently included the concept of group affinities, which allows users specify the affinity between groups for the seating distribution. However, these values were not used thus far. In this PR, we're modifying the calculator to take these values into account, instead of the previous distance-based affinity. We're also making the `AffinityGroupsHierarchy` not a singleton anymore, as that doesn't quite fit a multi-tenant system. Additionally, memoized variables would never be removed by the GC, leading to a memory leak at some point.
bustikiller added 1 commit 2025-01-19 19:59:50 +00:00
Use group affinities in discomfort calculator
All checks were successful
Check usage of free licenses / check-licenses (pull_request) Successful in 50s
Details
Add copyright notice / copyright_notice (pull_request) Successful in 1m11s
Details
Run unit tests / unit_tests (pull_request) Successful in 1m58s
Details
Build Nginx-based docker image / build-static-assets (pull_request) Successful in 19m18s
Details
1f0c6c2aac
bustikiller scheduled this pull request to auto merge when all checks succeed 2025-01-19 20:01:41 +00:00
bustikiller merged commit 7c968f555f into main 2025-01-19 20:19:10 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bustikiller/wedding-planner#215
No description provided.
Delete Branch "discomfort-calculation-revamp"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?