Extract rubocop to a separate job in CI

Merge pull request 'Fix error loading arrangements' (#217 ) from fix/error-loading-arrangements into main
Reviewed-on: #217
2025-01-23 22:07:04 +01:00 · 2025-01-23 20:49:01 +00:00 · 2025-01-23 03:11:38 +00:00 · 2025-01-22 20:39:09 +01:00
3 changed files with 15 additions and 7 deletions
--- a/.gitea/workflows/tests.yml
+++ b/.gitea/workflows/tests.yml
@ -24,7 +24,6 @@ jobs:
          token: ${{ secrets.GITHUB_TOKEN }}
      - uses: ruby/setup-ruby@v1.207.0
      - run: bundle install
-      - run: bundle exec rubocop --force-exclusion --parallel
      - name: Wait until Postgres is ready to accept connections
        run: |
          apt-get update && apt-get install -f -y postgresql-client
@ -42,3 +41,12 @@ jobs:
      - name: Clean up containers generated by this flow
        if: failure()
        run: docker ps --filter network=$JOB_CONTAINER_NAME-$GITHUB_JOB-network --filter name=$JOB_CONTAINER_NAME-* --format "{{.ID}}" | xargs docker rm -f
+  rubocop:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+      - uses: ruby/setup-ruby@v1.207.0
+      - run: bundle install
+      - run: bundle exec rubocop --force-exclusion --parallel
--- a/Gemfile.lock
+++ b/Gemfile.lock
@ -329,7 +329,7 @@ GEM
    rswag-ui (2.16.0)
      actionpack (>= 5.2, < 8.1)
      railties (>= 5.2, < 8.1)
-    rubocop (1.70.0)
+    rubocop (1.71.0)
      json (~> 2.3)
      language_server-protocol (>= 3.17.0)
      parallel (~> 1.10)
@ -578,7 +578,7 @@ CHECKSUMS
  rswag-api (2.16.0) sha256=b653f7bd92e98be18b01ab4525d88950d7b0960e293a99f856b9efcee3ae6074
  rswag-specs (2.16.0) sha256=8ba26085c408b0bd2ed21dc8015c80f417c7d34c63720ab7133c2549b5bd2a91
  rswag-ui (2.16.0) sha256=a1f49e927dceda92e6e6e7c1000f1e217ee66c565f69e28131dc98b33cd3a04f
-  rubocop (1.70.0) sha256=96751f8440b36a0ac6e9a8ab596900803118d83d6b83f2037bf8b3d7a5bc440e
+  rubocop (1.71.0) sha256=e19679efd447346ac476122313d3788ae23c38214790bcf660e984c747608bf0
  rubocop-ast (1.37.0) sha256=9513ac88aaf113d04b52912533ffe46475de1362d4aa41141b51b2455827c080
  rubocop-factory_bot (2.26.1) sha256=8de13cd4edcee5ca800f255188167ecef8dbfc3d1fae9f15734e9d2e755392aa
  rubocop-rails (2.29.0) sha256=35bffd140c80671453aafac0e2d5ab5b3dd65736a3fc8f3936ccca226b89c234
--- a/app/services/affinity_groups_hierarchy.rb
+++ b/app/services/affinity_groups_hierarchy.rb
@ -17,7 +17,7 @@ class AffinityGroupsHierarchy < Array
      hydrate(group)
    end

-    load_discomforts
+    discomforts
    freeze
  end

@ -58,9 +58,9 @@ class AffinityGroupsHierarchy < Array

  private

-  def load_discomforts
-    @load_discomforts ||= GroupAffinity.pluck(:group_a_id, :group_b_id,
-                                              :discomfort).each_with_object({}) do |(id_a, id_b, discomfort), acc|
+  def discomforts
+    @discomforts ||= GroupAffinity.pluck(:group_a_id, :group_b_id,
+                                         :discomfort).each_with_object({}) do |(id_a, id_b, discomfort), acc|
      acc[uuid_to_int(id_a) + uuid_to_int(id_b)] = discomfort
    end
  end
Author	SHA1	Message	Date
Manuel Bustillo	da02f37069	Extract rubocop to a separate job in CI Some checks failed Build Nginx-based docker image / build-static-assets (pull_request) Has been cancelled Details Check usage of free licenses / check-licenses (pull_request) Successful in 54s Details Add copyright notice / copyright_notice (pull_request) Successful in 1m32s Details Run unit tests / rubocop (pull_request) Successful in 45s Details Run unit tests / unit_tests (pull_request) Successful in 2m43s Details	2025-01-23 22:07:04 +01:00
bustikiller	006b1893c1	Merge pull request 'Fix error loading arrangements' (#217 ) from fix/error-loading-arrangements into main All checks were successful Check usage of free licenses / check-licenses (push) Successful in 1m24s Details Run unit tests / unit_tests (push) Successful in 1m31s Details Build Nginx-based docker image / build-static-assets (push) Successful in 28m7s Details Reviewed-on: #217	2025-01-23 20:49:01 +00:00
Renovate Bot	fcb1e77a3a	Update dependency rubocop to v1.71.0 All checks were successful Add copyright notice / copyright_notice (pull_request) Successful in 1m28s Details Check usage of free licenses / check-licenses (pull_request) Successful in 2m46s Details Build Nginx-based docker image / build-static-assets (pull_request) Successful in 17m11s Details Run unit tests / unit_tests (pull_request) Successful in 1m4s Details Check usage of free licenses / check-licenses (push) Successful in 42s Details Run unit tests / unit_tests (push) Successful in 2m6s Details Build Nginx-based docker image / build-static-assets (push) Successful in 14m32s Details	2025-01-23 03:11:38 +00:00
Manuel Bustillo	9f7f99f3f4	Fix error loading arrangements All checks were successful Run unit tests / unit_tests (pull_request) Successful in 5m3s Details Build Nginx-based docker image / build-static-assets (pull_request) Successful in 24m19s Details Add copyright notice / copyright_notice (pull_request) Successful in 34s Details Check usage of free licenses / check-licenses (pull_request) Successful in 37s Details	2025-01-22 20:39:09 +01:00