Extract rubocop to a separate job in CI

Reviewed-on: #217

Gemfile.lock

@@ -329,7 +329,7 @@ GEM
     rswag-ui (2.16.0)
       actionpack (>= 5.2, < 8.1)
       railties (>= 5.2, < 8.1)
-    rubocop (1.70.0)
+    rubocop (1.71.0)
       json (~> 2.3)
       language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
@@ -578,7 +578,7 @@ CHECKSUMS
   rswag-api (2.16.0) sha256=b653f7bd92e98be18b01ab4525d88950d7b0960e293a99f856b9efcee3ae6074
   rswag-specs (2.16.0) sha256=8ba26085c408b0bd2ed21dc8015c80f417c7d34c63720ab7133c2549b5bd2a91
   rswag-ui (2.16.0) sha256=a1f49e927dceda92e6e6e7c1000f1e217ee66c565f69e28131dc98b33cd3a04f
-  rubocop (1.70.0) sha256=96751f8440b36a0ac6e9a8ab596900803118d83d6b83f2037bf8b3d7a5bc440e
+  rubocop (1.71.0) sha256=e19679efd447346ac476122313d3788ae23c38214790bcf660e984c747608bf0
   rubocop-ast (1.37.0) sha256=9513ac88aaf113d04b52912533ffe46475de1362d4aa41141b51b2455827c080
   rubocop-factory_bot (2.26.1) sha256=8de13cd4edcee5ca800f255188167ecef8dbfc3d1fae9f15734e9d2e755392aa
   rubocop-rails (2.29.0) sha256=35bffd140c80671453aafac0e2d5ab5b3dd65736a3fc8f3936ccca226b89c234

README.md

@@ -57,17 +57,16 @@ The backend service will seed the database with fake data. It's worth noting tha
 
 The backend, frontend and workers have hot-reloading enabled, so changes made to the codebase should be reflected in the application on the next request.
 
-Once all containers have started, visit:
-
-- http://libre-wedding-planner.app.localhost/default to load the application.
-- http://libre-wedding-planner.app.localhost/letter_opener/ to get a list of emails generated by the application.
-- http://pghero.libre-wedding-planner.app.localhost to load the [pghero](https://github.com/ankane/pghero) tool.
+Once all containers have started, visit http://libre-wedding-planner.app.localhost/default/dashboard to load the application.
 
 ## Multitenancy
 
 LibreWeddingPlanner is designed to manage multiple weddings in a single host. All URLs (in the API and the frontend) are scoped under a slug that is unique per wedding. The slug is made of lowercase letters, numbers, and dashes (-).
 
 The development environment is seeded with a wedding whose slug is `default`.
+## Email delivery
+
+In the development environment, real emails will not be sent. You can visit http://libre-wedding-planner.app.localhost/letter_opener/ to get a list of emails generated by the application.
 
 ## Testing
 

app/services/affinity_groups_hierarchy.rb

@@ -17,7 +17,7 @@ class AffinityGroupsHierarchy < Array
       hydrate(group)
     end
 
-    load_discomforts
+    discomforts
     freeze
   end
 
@@ -58,9 +58,9 @@ class AffinityGroupsHierarchy < Array
 
   private
 
-  def load_discomforts
-    @load_discomforts ||= GroupAffinity.pluck(:group_a_id, :group_b_id,
-                                              :discomfort).each_with_object({}) do |(id_a, id_b, discomfort), acc|
+  def discomforts
+    @discomforts ||= GroupAffinity.pluck(:group_a_id, :group_b_id,
+                                         :discomfort).each_with_object({}) do |(id_a, id_b, discomfort), acc|
       acc[uuid_to_int(id_a) + uuid_to_int(id_b)] = discomfort
     end
   end

db/migrate/20250122202836_enable_pg_stat_statements.rb

@@ -1,5 +0,0 @@
-class EnablePgStatStatements < ActiveRecord::Migration[8.0]
-  def change
-    enable_extension 'pg_stat_statements'
-  end
-end

db/migrate/20250122204932_create_pghero_stats_tables.rb

@@ -1,21 +0,0 @@
-class CreatePgheroStatsTables < ActiveRecord::Migration[8.0]
-  def up
-    execute <<~SQL
-      CREATE TABLE "pghero_query_stats" (
-        "id" bigserial primary key,
-        "database" text,
-        "user" text,
-        "query" text,
-        "query_hash" bigint,
-        "total_time" float,
-        "calls" bigint,
-        "captured_at" timestamp
-      );
-      CREATE INDEX ON "pghero_query_stats" ("database", "captured_at");
-    SQL
-  end
-
-  def down
-    drop_table :pghero_query_stats, if_exists: true, force: :cascade
-  end
-end

db/schema.rb

@@ -1,3 +1,7 @@
+# Copyright (C) 2024 Manuel Bustillo
+
+# Copyright (C) 2024-2025 LibreWeddingPlanner contributors
+
 # This file is auto-generated from the current state of the database. Instead
 # of editing this file, please use the migrations feature of Active Record to
 # incrementally modify your database, and then regenerate this schema definition.
@@ -10,10 +14,9 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema[8.0].define(version: 2025_01_22_204932) do
+ActiveRecord::Schema[8.0].define(version: 2024_12_16_231415) do
   # These are extensions that must be enabled in order to support this database
   enable_extension "pg_catalog.plpgsql"
-  enable_extension "pg_stat_statements"
 
   # Custom types defined in this database.
   # Note that some types may not work with other database engines. Be careful if changing database.
@@ -68,17 +71,6 @@ ActiveRecord::Schema[8.0].define(version: 2025_01_22_204932) do
     t.index ["wedding_id"], name: "index_guests_on_wedding_id"
   end
 
-  create_table "pghero_query_stats", force: :cascade do |t|
-    t.text "database"
-    t.text "user"
-    t.text "query"
-    t.bigint "query_hash"
-    t.float "total_time"
-    t.bigint "calls"
-    t.datetime "captured_at", precision: nil
-    t.index ["database", "captured_at"], name: "pghero_query_stats_database_captured_at_idx"
-  end
-
   create_table "seats", id: :uuid, default: -> { "gen_random_uuid()" }, force: :cascade do |t|
     t.uuid "guest_id", null: false
     t.uuid "tables_arrangement_id", null: false

docker-compose.yml

@@ -74,19 +74,10 @@ services:
       POSTGRES_USER: postgres
       POSTGRES_PASSWORD: postgres
       POSTGRES_DB: postgres
-    command: postgres -c shared_preload_libraries='pg_stat_statements' -c pg_stat_statements.track=all
     healthcheck:
       test: ['CMD-SHELL', 'pg_isready -U postgres']
       interval: 10s
       timeout: 5s
       retries: 5
-  pghero:
-    image: ankane/pghero
-    ports:
-      - 8080
-    environment:
-      DATABASE_URL: postgres://postgres:postgres@db:5432/postgres
-    depends_on:
-      db:
-        condition: service_healthy
+
    

nginx.conf

@@ -23,12 +23,3 @@ server {
     }
 }
 
-server {
-    listen 80;
-    server_name pghero.libre-wedding-planner.app.localhost;
-
-    location / {
-        proxy_pass http://pghero:8080;
-        proxy_set_header Host $http_host;
-    }
-}