bustikiller/wedding-planner
1
0
Fork 0
Code Issues Pull Requests 6 Actions Packages Projects Releases Wiki Activity

Redo simulations lifecycle #222

Merged
bustikiller merged 6 commits from table-arrangements-guest-digest into main 2025-01-26 12:53:22 +00:00
Conversation 0 Commits 6 Files Changed 9 +52 -17
bustikiller commented 2025-01-26 09:20:31 +00:00
Owner
Copy Link

Why

The current way of creating and deleting simulations doesn't scale for big instances. We cannot generate 50 simulations every time a guest confirms attendance, and we should not delete existing valuable simulations. For example, if a guest confirms attendance and declines right after, previously generated simulations should still be valid.

What

In this PR we are introducing a series of changes that make simulations management easier:

  1. We're removing the automatic creation of simulations.
  2. Simulations are not removed anymore, neither manually nor automatically.
  3. A new endpoint has been defined to create simulations on demand.
  4. A digest property has been defined to determine whether a simulation is still valid (meaning there have not been any change in the list of guests involved).
## Why The current way of creating and deleting simulations doesn't scale for big instances. We cannot generate 50 simulations every time a guest confirms attendance, and we should not delete existing valuable simulations. For example, if a guest confirms attendance and declines right after, previously generated simulations should still be valid. ## What In this PR we are introducing a series of changes that make simulations management easier: 1. We're removing the automatic creation of simulations. 2. Simulations are not removed anymore, neither manually nor automatically. 3. A new endpoint has been defined to create simulations on demand. 4. A digest property has been defined to determine whether a simulation is still valid (meaning there have not been any change in the list of guests involved).
bustikiller added 1 commit 2025-01-26 09:20:31 +00:00
Define a new column to store the digest of the list of guests included in a simulation
Some checks failed
Run unit tests / check-licenses (pull_request) Successful in 43s
Details
Run unit tests / rubocop (pull_request) Successful in 1m5s
Details
Run unit tests / copyright_notice (pull_request) Successful in 1m7s
Details
Run unit tests / unit_tests (pull_request) Successful in 3m6s
Details
Run unit tests / build-static-assets (pull_request) Has been cancelled
Details
d1a351ffec
bustikiller added 5 commits 2025-01-26 12:36:36 +00:00
Define a new endpoint to create simulations
All checks were successful
Run unit tests / copyright_notice (pull_request) Successful in 1m3s
Details
Run unit tests / rubocop (pull_request) Successful in 1m28s
Details
Run unit tests / check-licenses (pull_request) Successful in 1m33s
Details
Run unit tests / unit_tests (pull_request) Successful in 1m4s
Details
Run unit tests / build-static-assets (pull_request) Successful in 12m29s
Details
998c0f43f3
bustikiller changed title from WIP: Expire simulations based on guest digest to Redo simulations lifecycle 2025-01-26 12:36:55 +00:00
bustikiller scheduled this pull request to auto merge when all checks succeed 2025-01-26 12:41:25 +00:00
bustikiller merged commit 2147d7ad5e into main 2025-01-26 12:53:22 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bustikiller/wedding-planner#222
No description provided.
Delete Branch "table-arrangements-guest-digest"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?