Merge pull request 'rubocop-autocorrect' (#202) from rubocop-autocorrect into main

Reviewed-on: #202

.gitea/workflows/tests.yml

@@ -24,6 +24,7 @@ jobs:
           token: ${{ secrets.GITHUB_TOKEN }}
       - uses: ruby/setup-ruby@v1.202.0
       - run: bundle install
+      - run: bundle exec rubocop --force-exclusion --parallel
       - name: Wait until Postgres is ready to accept connections
         run: |
           apt-get update && apt-get install -f -y postgresql-client

.rubocop.yml

@@ -0,0 +1,29 @@
+require:
+  - rubocop-rails
+  - rubocop-factory_bot
+  - rubocop-rspec
+  - rubocop-rspec_rails
+AllCops:
+  NewCops: enable
+  Exclude:
+    - 'db/**/*'
+    - 'config/**/*'
+    - 'script/**/*'
+    - 'bin/*'
+    - '*.yml'
+Layout/LineLength:
+  Max: 120
+RSpec/ExampleLength:
+  Enabled: false
+Metrics/ModuleLength:
+  Enabled: false
+RSpec/MultipleMemoizedHelpers:
+  Enabled: false
+Style/Documentation:
+  Enabled: false
+Metrics/MethodLength:
+  Max: 20
+Rails/SkipsModelValidations:
+  Enabled: false
+Metrics/AbcSize:
+  Enabled: false

Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 ruby '3.3.6'
@@ -15,15 +17,15 @@ gem 'stimulus-rails'
 gem 'turbo-rails'
 gem 'tzinfo-data', platforms: %i[windows jruby]
 
+gem 'acts_as_tenant'
 gem 'faker'
+gem 'httparty'
 gem 'jsonapi-rails'
+gem 'pluck_to_hash'
 gem 'rack-cors'
 gem 'react-rails'
-gem 'rubytree'
-gem 'acts_as_tenant'
-gem 'httparty'
 gem 'rswag'
-gem 'pluck_to_hash'
+gem 'rubytree'
 
 group :development, :test do
   gem 'annotaterb'
@@ -36,12 +38,16 @@ group :development, :test do
 end
 
 group :development do
-  gem 'rubocop'
-  gem 'web-console'
   gem 'letter_opener_web'
+  gem 'rubocop'
+  gem 'rubocop-factory_bot', require: false
+  gem 'rubocop-rails', require: false
+  gem 'rubocop-rspec', require: false
+  gem 'rubocop-rspec_rails', require: false
+  gem 'web-console'
 end
 
 gem 'chroma'
 gem 'solid_queue', '~> 1.0'
 
-gem "devise", "~> 4.9"
+gem 'devise', '~> 4.9'

Gemfile.lock

@@ -339,6 +339,18 @@ GEM
       unicode-display_width (>= 2.4.0, < 4.0)
     rubocop-ast (1.36.2)
       parser (>= 3.3.1.0)
+    rubocop-factory_bot (2.26.1)
+      rubocop (~> 1.61)
+    rubocop-rails (2.28.0)
+      activesupport (>= 4.2.0)
+      rack (>= 1.1)
+      rubocop (>= 1.52.0, < 2.0)
+      rubocop-ast (>= 1.31.1, < 2.0)
+    rubocop-rspec (3.3.0)
+      rubocop (~> 1.61)
+    rubocop-rspec_rails (2.30.0)
+      rubocop (~> 1.61)
+      rubocop-rspec (~> 3, >= 3.0.1)
     ruby-progressbar (1.13.0)
     rubytree (2.1.0)
       json (~> 2.0, > 2.3.1)
@@ -426,6 +438,10 @@ DEPENDENCIES
   rspec-rails (~> 7.1.0)
   rswag
   rubocop
+  rubocop-factory_bot
+  rubocop-rails
+  rubocop-rspec
+  rubocop-rspec_rails
   rubytree
   shoulda-matchers (~> 6.0)
   solid_queue (~> 1.0)
@@ -561,6 +577,10 @@ CHECKSUMS
   rswag-ui (2.16.0) sha256=a1f49e927dceda92e6e6e7c1000f1e217ee66c565f69e28131dc98b33cd3a04f
   rubocop (1.69.2) sha256=762fb0f30a379bf6054588d39f1815a2a1df8f067bc0337d3fe500e346924bb8
   rubocop-ast (1.36.2) sha256=566405b7f983eb9aa3b91d28aca6bc6566e356a97f59e89851dd910aef1dd1ca
+  rubocop-factory_bot (2.26.1) sha256=8de13cd4edcee5ca800f255188167ecef8dbfc3d1fae9f15734e9d2e755392aa
+  rubocop-rails (2.28.0) sha256=4967bed9ea13e6dcab566fea4265a6dd0381db739b305e48930aba1282da2715
+  rubocop-rspec (3.3.0) sha256=79e1b281a689044d1516fefbc52e2e6c06cd367c25ebeaf06a7a198e9071cd7d
+  rubocop-rspec_rails (2.30.0) sha256=888112e83f9d7ef7ad2397e9d69a0b9614a4bae24f072c399804a180f80c4c46
   ruby-progressbar (1.13.0) sha256=80fc9c47a9b640d6834e0dc7b3c94c9df37f08cb072b7761e4a71e22cff29b33
   rubytree (2.1.0) sha256=30e8759ba060dff0dabf7e40cbaaa4df892fa34cbe9f1b3fbb00e83a3f321e4b
   rubyzip (2.3.2) sha256=3f57e3935dc2255c414484fbf8d673b4909d8a6a57007ed754dde39342d2373f

Rakefile

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 # Add your own tasks in files placed in lib/tasks ending in .rake,
 # for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
 
-require_relative "config/application"
+require_relative 'config/application'
 
 Rails.application.load_tasks

app/channels/application_cable/channel.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 module ApplicationCable
   class Channel < ActionCable::Channel::Base
   end

app/channels/application_cable/connection.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 module ApplicationCable
   class Connection < ActionCable::Connection::Base
   end

app/controllers/affinities_controller.rb

@@ -6,22 +6,27 @@ class AffinitiesController < ApplicationController
   before_action :set_group
 
   def index
-    overridden_affinities = @group.affinities
-      .each_with_object({}) { |affinity, acc| acc[affinity.another_group(@group).id] = affinity.discomfort }
-    Group.where.not(id: @group.id).pluck(:id).index_with { |group_id| GroupAffinity::MAX_DISCOMFORT - (overridden_affinities[group_id] || GroupAffinity::NEUTRAL) }
+    overridden = @group.affinities.each_with_object({}) do |affinity, acc|
+      acc[affinity.another_group(@group).id] = affinity.discomfort
+    end
+    Group.where.not(id: @group.id)
+         .pluck(:id)
+         .index_with { |group_id| GroupAffinity::MAX_DISCOMFORT - (overridden[group_id] || GroupAffinity::NEUTRAL) }
          .then { |affinities| render json: affinities }
   end
 
   def bulk_update
-    params.expect(affinities: [[:group_id, :affinity]]).map(&:to_h).map do |affinity|
+    affinities = params.expect(affinities: [%i[group_id affinity]]).map(&:to_h).map do |affinity|
       {
         group_a_id: @group.id,
         group_b_id: affinity[:group_id],
         discomfort: GroupAffinity::MAX_DISCOMFORT - affinity[:affinity]
       }
-    end.then { |affinities| GroupAffinity.upsert_all(affinities) }
-    render json: {}, status: :ok
+    end
 
+    GroupAffinity.upsert_all(affinities)
+
+    render json: {}, status: :ok
   rescue ActiveRecord::InvalidForeignKey
     render json: { error: 'At least one of the group IDs provided does not exist.' }, status: :bad_request
   rescue ActiveRecord::StatementInvalid

app/controllers/application_controller.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 class ApplicationController < ActionController::Base
   set_current_tenant_through_filter
   before_action :set_tenant
@@ -40,7 +42,7 @@ class ApplicationController < ActionController::Base
   end
 
   def captcha_params
-    params.expect(captcha: [:id, :answer])
+    params.expect(captcha: %i[id answer])
   end
 
   def default_url_options(options = {})
@@ -53,7 +55,7 @@ class ApplicationController < ActionController::Base
 
   def development_swagger?
     Rails.env.test? ||
-      Rails.env.development? && request.headers['referer']&.include?('/api-docs/index.html')
+      (Rails.env.development? && request.headers['referer']&.include?('/api-docs/index.html'))
   end
 
   def set_csrf_cookie

app/controllers/captcha_controller.rb

@@ -1,10 +1,12 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 class CaptchaController < ApplicationController
   skip_before_action :authenticate_user!
   skip_before_action :set_tenant
   def create
-    id = LibreCaptcha.new.get_id
+    id = LibreCaptcha.new.id
     render json: {
       id:,
       media_url: media_captcha_index_url(id:)

app/controllers/expenses_controller.rb

@@ -1,12 +1,14 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 class ExpensesController < ApplicationController
   def summary
     render json: Expenses::TotalQuery.new.call
   end
 
   def index
-    render json: Expense.all.order(pricing_type: :asc, amount: :desc).as_json(only: %i[id name amount pricing_type])
+    render json: Expense.order(pricing_type: :asc, amount: :desc).as_json(only: %i[id name amount pricing_type])
   end
 
   def create

app/controllers/groups_controller.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 class GroupsController < ApplicationController
   def index
     query_result = Groups::SummaryQuery.new.call.as_json.map(&:deep_symbolize_keys).map do |group|
@@ -39,6 +41,6 @@ class GroupsController < ApplicationController
   end
 
   def group_params
-    params.expect(group: [:name, :icon, :color])
+    params.expect(group: %i[name icon color])
   end
 end

app/controllers/guests_controller.rb

@@ -1,10 +1,12 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 require 'csv'
 
 class GuestsController < ApplicationController
   def index
-    render json: Guest.all.includes(:group)
+    render json: Guest.includes(:group)
                       .left_joins(:group)
                       .order('groups.name' => :asc, name: :asc)
                       .as_json(only: %i[id name status], include: { group: { only: %i[id name] } })

app/controllers/summary_controller.rb

@@ -1,11 +1,33 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 class SummaryController < ApplicationController
   def index
-    expense_summary = Expenses::TotalQuery.new(wedding: ActsAsTenant.current_tenant).call
-    guest_summary = Guest.group(:status).count
     render json: {
-      expenses: {
+      expenses:,
+      guests:
+    }
+  end
+
+  private
+
+  def guests
+    guest_summary = Guest.group(:status).count
+
+    {
+      total: guest_summary.except('considered').values.sum,
+      confirmed: guest_summary['confirmed'].to_i,
+      declined: guest_summary['declined'].to_i,
+      tentative: guest_summary['tentative'].to_i,
+      invited: guest_summary['invited'].to_i
+    }
+  end
+
+  def expenses
+    expense_summary = Expenses::TotalQuery.new(wedding: ActsAsTenant.current_tenant).call
+
+    {
       projected: {
         total: expense_summary['total_projected'],
         guests: expense_summary['projected_guests']
@@ -17,14 +39,6 @@ class SummaryController < ApplicationController
       status: {
         paid: 0
       }
-      },
-      guests: {
-        total: guest_summary.except('considered').values.sum,
-        confirmed: guest_summary['confirmed'].to_i,
-        declined: guest_summary['declined'].to_i,
-        tentative: guest_summary['tentative'].to_i,
-        invited: guest_summary['invited'].to_i
-      }
     }
   end
 end

app/controllers/tables_arrangements_controller.rb

@@ -1,8 +1,10 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 class TablesArrangementsController < ApplicationController
   def index
-    render json: TablesArrangement.all.order(discomfort: :asc).limit(3).as_json(only: %i[id name discomfort])
+    render json: TablesArrangement.order(discomfort: :asc).limit(3).as_json(only: %i[id name discomfort])
   end
 
   def show

app/controllers/tokens_controller.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 class TokensController < ApplicationController
   skip_before_action :authenticate_user!
   skip_before_action :set_tenant

app/controllers/users/confirmations_controller.rb

@@ -1,6 +1,9 @@
 # Copyright (C) 2024 Manuel Bustillo
 
-class Users::ConfirmationsController < Devise::ConfirmationsController
+# frozen_string_literal: true
+
+module Users
+  class ConfirmationsController < Devise::ConfirmationsController
     clear_respond_to
     respond_to :json
 
@@ -21,3 +24,4 @@ class Users::ConfirmationsController < Devise::ConfirmationsController
       end
     end
   end
+end

app/controllers/users/registrations_controller.rb

@@ -1,6 +1,9 @@
 # Copyright (C) 2024 Manuel Bustillo
 
-class Users::RegistrationsController < Devise::RegistrationsController
+# frozen_string_literal: true
+
+module Users
+  class RegistrationsController < Devise::RegistrationsController
     clear_respond_to
     respond_to :json
 
@@ -26,3 +29,4 @@ class Users::RegistrationsController < Devise::RegistrationsController
       set_current_tenant(nil)
     end
   end
+end

app/controllers/users/sessions_controller.rb

@@ -1,6 +1,10 @@
 # Copyright (C) 2024 Manuel Bustillo
 
-class Users::SessionsController < Devise::SessionsController
+# frozen_string_literal: true
+
+module Users
+  class SessionsController < Devise::SessionsController
     clear_respond_to
     respond_to :json
   end
+end

app/extensions/tree_node_extension.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 module TreeNodeExtension
   def distance_to_common_ancestor(another_node)
     return 0 if self == another_node

app/helpers/application_helper.rb

@@ -1,4 +1,6 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 module ApplicationHelper
 end

app/helpers/expenses_helper.rb

@@ -1,4 +1,6 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 module ExpensesHelper
 end

app/helpers/groups_helper.rb

@@ -1,4 +1,6 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 module GroupsHelper
 end

app/helpers/guests_helper.rb

@@ -1,4 +1,6 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 module GuestsHelper
 end

app/helpers/tables_arrangements_helper.rb

@@ -1,4 +1,6 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 module TablesArrangementsHelper
 end

app/jobs/application_job.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 class ApplicationJob < ActiveJob::Base
   # Automatically retry jobs that encountered a deadlock
   # retry_on ActiveRecord::Deadlocked

app/jobs/table_simulator_job.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 class TableSimulatorJob < ApplicationJob
   queue_as :default
 

app/mailers/application_mailer.rb

@@ -1,6 +1,8 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 class ApplicationMailer < ActionMailer::Base
-  default from: "from@example.com"
-  layout "mailer"
+  default from: 'from@example.com'
+  layout 'mailer'
 end

app/models/application_record.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 class ApplicationRecord < ActiveRecord::Base
   primary_abstract_class
 end

app/models/expense.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 # == Schema Information
 #
 # Table name: expenses

app/models/group.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 # == Schema Information
 #
 # Table name: groups
@@ -31,7 +33,7 @@ class Group < ApplicationRecord
   validates :name, uniqueness: true
   validates :name, :order, presence: true
 
-  has_many :children, class_name: 'Group', foreign_key: 'parent_id'
+  has_many :children, class_name: 'Group', foreign_key: 'parent_id', dependent: :nullify, inverse_of: :parent
   belongs_to :parent, class_name: 'Group', optional: true
 
   before_create :set_color
@@ -41,10 +43,7 @@ class Group < ApplicationRecord
   has_many :guests, dependent: :nullify
 
   def colorize_children(generation = 1)
-    derived_colors = generation == 1 ? color.paint.palette.analogous(size: children.count) : color.paint.palette.decreasing_saturation
-
-    children.zip(derived_colors) do |child, raw_color|
-
+    children.zip(palette(generation)) do |child, raw_color|
       final_color = raw_color.paint
       final_color.brighten(60) if final_color.dark?
 
@@ -60,6 +59,14 @@ class Group < ApplicationRecord
 
   private
 
+  def palette(generation)
+    if generation == 1
+      color.paint.palette.analogous(size: children.count)
+    else
+      color.paint.palette.decreasing_saturation
+    end
+  end
+
   def set_color
     return if color.present?
 

app/models/group_affinity.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 # == Schema Information
 #
 # Table name: group_affinities
@@ -30,7 +32,8 @@ class GroupAffinity < ApplicationRecord
   belongs_to :group_a, class_name: 'Group'
   belongs_to :group_b, class_name: 'Group'
 
-  validates :discomfort, numericality: { greater_than_or_equal_to: MIN_DISCOMFORT, less_than_or_equal_to: MAX_DISCOMFORT }
+  validates :discomfort,
+            numericality: { greater_than_or_equal_to: MIN_DISCOMFORT, less_than_or_equal_to: MAX_DISCOMFORT }
 
   def another_group(group)
     return nil if group != group_a && group != group_b

app/models/guest.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 # == Schema Information
 #
 # Table name: guests
@@ -39,8 +41,8 @@ class Guest < ApplicationRecord
 
   scope :potential, -> { where.not(status: %i[declined considered]) }
 
-  after_save :recalculate_simulations, if: :saved_change_to_status?
   after_destroy :recalculate_simulations
+  after_save :recalculate_simulations, if: :saved_change_to_status?
 
   has_many :seats, dependent: :delete_all
 

app/models/seat.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 # == Schema Information
 #
 # Table name: seats

app/models/tables_arrangement.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 # == Schema Information
 #
 # Table name: tables_arrangements
@@ -21,7 +23,7 @@
 #
 class TablesArrangement < ApplicationRecord
   acts_as_tenant :wedding
-  has_many :seats
+  has_many :seats, dependent: :delete_all
   has_many :guests, through: :seats
 
   before_create :assign_name

app/models/user.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 # == Schema Information
 #
 # Table name: users

app/models/wedding.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 # == Schema Information
 #
 # Table name: weddings

app/queries/expenses/total_query.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 module Expenses
   class TotalQuery
     private attr_reader :wedding
@@ -16,7 +18,7 @@ module Expenses
     private
 
     def query
-      <<~SQL
+      <<~SQL.squish
         WITH guest_count AS (#{guest_count_per_status}),
              expense_summary AS (#{expense_summary})
         SELECT guest_count.confirmed as confirmed_guests,
@@ -28,7 +30,7 @@ module Expenses
     end
 
     def expense_summary
-      <<~SQL
+      <<~SQL.squish
         SELECT coalesce(sum(amount) filter (where pricing_type = 'fixed'), 0) as fixed,
                coalesce(sum(amount) filter (where pricing_type = 'per_person'), 0) as variable
         FROM expenses
@@ -37,7 +39,7 @@ module Expenses
     end
 
     def guest_count_per_status
-      <<~SQL
+      <<~SQL.squish
         SELECT COALESCE(count(*) filter(where status = #{Guest.statuses['confirmed']}), 0) as confirmed,
                COALESCE(count(*) filter(where status IN (#{Guest.statuses.values_at('confirmed', 'invited', 'tentative').join(',')})), 0) as projected
         FROM guests

app/queries/groups/summary_query.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 module Groups
   class SummaryQuery
     def call
@@ -9,13 +11,21 @@ module Groups
         :icon,
         :parent_id,
         :color,
+        *count_expressions
+      )
+    end
+
+    private
+
+    def count_expressions
+      [
         Arel.sql('count(*) filter (where status IS NOT NULL) as total'),
         Arel.sql('count(*) filter (where status = 0) as considered'),
         Arel.sql('count(*) filter (where status = 10) as invited'),
         Arel.sql('count(*) filter (where status = 20) as confirmed'),
         Arel.sql('count(*) filter (where status = 30) as declined'),
-        Arel.sql('count(*) filter (where status = 40) as tentative'),
-      )
+        Arel.sql('count(*) filter (where status = 40) as tentative')
+      ]
     end
   end
 end

app/serializers/serializable_group.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 class SerializableGroup < JSONAPI::Serializable::Resource
   type 'group'
 

app/serializers/serializable_guest.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 class SerializableGuest < JSONAPI::Serializable::Resource
   type 'guest'
 

app/services/affinity_groups_hierarchy.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 class AffinityGroupsHierarchy < Array
   include Singleton
 

app/services/libre_captcha.rb

@@ -1,20 +1,20 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 class LibreCaptcha
-  def get_id
-    HTTParty.post("http://libre-captcha:8888/v2/captcha", 
+  def id
+    HTTParty.post('http://libre-captcha:8888/v2/captcha',
                   body: {
-        input_type: "text",
+                    input_type: 'text',
                     level: :hard,
                     media: 'image/png',
                     size: '350x100'
-      }.to_json
-    ).then { |raw| JSON.parse(raw)['id'] }
+                  }.to_json).then { |raw| JSON.parse(raw)['id'] }
   end
 
   def valid?(id:, answer:)
-    HTTParty.post("http://libre-captcha:8888/v2/answer",
-      body: { id:, answer: }.to_json
-    ).then { |raw| JSON.parse(raw)['result'] == 'True' }
+    HTTParty.post('http://libre-captcha:8888/v2/answer',
+                  body: { id:, answer: }.to_json).then { |raw| JSON.parse(raw)['result'] == 'True' }
   end
 end

app/services/tables/discomfort_calculator.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 module Tables
   class DiscomfortCalculator
     class << self
@@ -7,6 +9,7 @@ module Tables
         distance = AffinityGroupsHierarchy.instance.distance(id_a, id_b)
 
         return 1 if distance.nil?
+
         Rational(distance, distance + 1)
       end
     end

app/services/tables/distribution.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 require_relative '../../extensions/tree_node_extension'
 
 module Tables

app/services/tables/shift.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 module Tables
   class Shift
     private attr_reader :initial_solution

app/services/tables/swap.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 module Tables
   class Swap
     private attr_reader :initial_solution

app/services/tables/table.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 module Tables
   class Table < Set
     attr_accessor :discomfort, :min_per_table, :max_per_table

app/services/vns/engine.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 module VNS
   class Engine
     class << self

config.ru

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 # This file is used by Rack-based servers to start the application.
 
-require_relative "config/environment"
+require_relative 'config/environment'
 
 run Rails.application
 Rails.application.load_server

lib/tasks/annotate_rb.rake

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 # This rake task was added by annotate_rb gem.
 
 # Can set `ANNOTATERB_SKIP_ON_DB_TASKS` to be anything to skip this
-if Rails.env.development? && ENV["ANNOTATERB_SKIP_ON_DB_TASKS"].nil?
-  require "annotate_rb"
+if Rails.env.development? && ENV['ANNOTATERB_SKIP_ON_DB_TASKS'].nil?
+  require 'annotate_rb'
 
   AnnotateRb::Core.load_rake_tasks
 end

spec/extensions/tree_spec.rb

@@ -1,70 +1,72 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 module Tree
   RSpec.describe TreeNode do
     describe '#distance_to_common_ancestor' do
-      def assert_distance(node_1, node_2, distance)
+      def assert_distance(node1, node2, distance)
         aggregate_failures do
-          expect(node_1.distance_to_common_ancestor(node_2)).to eq(distance)
-          expect(node_2.distance_to_common_ancestor(node_1)).to eq(distance)
+          expect(node1.distance_to_common_ancestor(node2)).to eq(distance)
+          expect(node2.distance_to_common_ancestor(node1)).to eq(distance)
         end
       end
       context 'when the two nodes are the same' do
         it 'returns 0 when comparing the root itself' do
-          root = Tree::TreeNode.new('root')
+          root = described_class.new('root')
           assert_distance(root, root, 0)
         end
 
         it 'returns 0 when comparing a child to itself' do
-          root = Tree::TreeNode.new('root')
-          child = root << Tree::TreeNode.new('child')
+          root = described_class.new('root')
+          child = root << described_class.new('child')
           assert_distance(child, child, 0)
         end
       end
 
       context 'when the two nodes are siblings' do
         it 'returns 1 when comparing siblings' do
-          root = Tree::TreeNode.new('root')
-          child1 = root << Tree::TreeNode.new('child1')
-          child2 = root << Tree::TreeNode.new('child2')
+          root = described_class.new('root')
+          child1 = root << described_class.new('child1')
+          child2 = root << described_class.new('child2')
           assert_distance(child1, child2, 1)
         end
       end
 
       context 'when one node is parent of the other' do
         it 'returns 1 when comparing parent to child' do
-          root = Tree::TreeNode.new('root')
-          child = root << Tree::TreeNode.new('child')
+          root = described_class.new('root')
+          child = root << described_class.new('child')
           assert_distance(root, child, 1)
         end
       end
 
       context 'when one node is grandparent of the other' do
         it 'returns 2 when comparing grandparent to grandchild' do
-          root = Tree::TreeNode.new('root')
-          child = root << Tree::TreeNode.new('child')
-          grandchild = child << Tree::TreeNode.new('grandchild')
+          root = described_class.new('root')
+          child = root << described_class.new('child')
+          grandchild = child << described_class.new('grandchild')
           assert_distance(root, grandchild, 2)
         end
       end
 
       context 'when the two nodes are cousins' do
         it 'returns 2 when comparing cousins' do
-          root = Tree::TreeNode.new('root')
-          child1 = root << Tree::TreeNode.new('child1')
-          child2 = root << Tree::TreeNode.new('child2')
-          grandchild1 = child1 << Tree::TreeNode.new('grandchild1')
-          grandchild2 = child2 << Tree::TreeNode.new('grandchild2')
+          root = described_class.new('root')
+          child1 = root << described_class.new('child1')
+          child2 = root << described_class.new('child2')
+          grandchild1 = child1 << described_class.new('grandchild1')
+          grandchild2 = child2 << described_class.new('grandchild2')
           assert_distance(grandchild1, grandchild2, 2)
         end
       end
 
       context 'when the two nodes are not related' do
         it 'returns nil' do
-          root = Tree::TreeNode.new('root')
-          another_root = Tree::TreeNode.new('another_root')
+          root = described_class.new('root')
+          another_root = described_class.new('another_root')
           assert_distance(root, another_root, nil)
         end
       end

spec/factories/expense.rb

@@ -1,19 +1,22 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# Copyright (C) 2024 Manuel Bustillo
+
+# frozen_string_literal: true
+
 FactoryBot.define do
   factory :expense do
     wedding
     sequence(:name) { |i| "Expense #{i}" }
-      pricing_type { "fixed" }
+    pricing_type { 'fixed' }
     amount { 100 }
   end
 
   trait :fixed do
-      pricing_type { "fixed" }
+    pricing_type { 'fixed' }
   end
 
   trait :per_person do
-      pricing_type { "per_person" }
+    pricing_type { 'per_person' }
   end
 end
-  

spec/factories/group_affinities.rb

@@ -1,9 +1,13 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# Copyright (C) 2024 Manuel Bustillo
+
+# frozen_string_literal: true
+
 FactoryBot.define do
   factory :group_affinity do
-    association :group_a, factory: :group
-    association :group_b, factory: :group
+    group_a factory: %i[group]
+    group_b factory: %i[group]
     discomfort { GroupAffinity::NEUTRAL }
   end
 end

spec/factories/groups.rb

@@ -1,5 +1,9 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# Copyright (C) 2024 Manuel Bustillo
+
+# frozen_string_literal: true
+
 FactoryBot.define do
   factory :group do
     wedding

spec/factories/guest.rb

@@ -1,5 +1,9 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# Copyright (C) 2024 Manuel Bustillo
+
+# frozen_string_literal: true
+
 FactoryBot.define do
   factory :guest do
     group

spec/factories/table_arrangement.rb

@@ -1,8 +1,11 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# Copyright (C) 2024 Manuel Bustillo
+
+# frozen_string_literal: true
+
 FactoryBot.define do
   factory :tables_arrangement do
     wedding
   end
 end
-  

spec/factories/users.rb

@@ -1,5 +1,9 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# Copyright (C) 2024 Manuel Bustillo
+
+# frozen_string_literal: true
+
 FactoryBot.define do
   factory :user do
     wedding

spec/factories/weddings.rb

@@ -1,5 +1,9 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# Copyright (C) 2024 Manuel Bustillo
+
+# frozen_string_literal: true
+
 FactoryBot.define do
   factory :wedding do
     sequence(:slug) { |i| "wedding-#{i}" }

spec/models/expense_spec.rb

@@ -1,12 +1,16 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# Copyright (C) 2024 Manuel Bustillo
+
+# frozen_string_literal: true
+
 require 'rails_helper'
 
-RSpec.describe Expense, type: :model do
+RSpec.describe Expense do
   describe 'validations' do
-    it { should validate_presence_of(:name) }
-    it { should validate_presence_of(:amount) }
-    it { should validate_numericality_of(:amount).is_greater_than(0) }
-    it { should validate_presence_of(:pricing_type) }
+    it { is_expected.to validate_presence_of(:name) }
+    it { is_expected.to validate_presence_of(:amount) }
+    it { is_expected.to validate_numericality_of(:amount).is_greater_than(0) }
+    it { is_expected.to validate_presence_of(:pricing_type) }
   end
 end

spec/models/group_affinity_spec.rb

@@ -4,16 +4,20 @@
 
 require 'rails_helper'
 
-RSpec.describe GroupAffinity, type: :model do
+RSpec.describe GroupAffinity do
+  subject(:affinity) { build(:group_affinity, group_a:, group_b:) }
+
   let(:wedding) { create(:wedding) }
   let(:group_a) { create(:group, wedding:) }
   let(:group_b) { create(:group, wedding:) }
   let(:group_c) { create(:group, wedding:) }
 
-  subject { build(:group_affinity, group_a:, group_b: ) }
-
   describe 'validations' do
-    it { should validate_numericality_of(:discomfort).is_greater_than_or_equal_to(0).is_less_than_or_equal_to(2) }
+    it do
+      expect(affinity).to validate_numericality_of(:discomfort)
+        .is_greater_than_or_equal_to(0)
+        .is_less_than_or_equal_to(2)
+    end
   end
 
   describe '.create' do

spec/models/group_spec.rb

@@ -1,10 +1,14 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# Copyright (C) 2024 Manuel Bustillo
+
+# frozen_string_literal: true
+
 require 'rails_helper'
 
-RSpec.describe Group, type: :model do
+RSpec.describe Group do
   describe 'callbacks' do
-    it 'should set color before create' do
+    it 'sets color before create' do
       expect(create(:group).color).to be_present
     end
   end

spec/models/guest_spec.rb

@@ -1,12 +1,17 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 require 'rails_helper'
 
-RSpec.describe Guest, type: :model do
+RSpec.describe Guest do
   describe 'validations' do
-    it { should validate_presence_of(:name) }
+    subject(:guest) { build(:guest) }
+
+    it { is_expected.to validate_presence_of(:name) }
+
     it do
-      should define_enum_for(:status).with_values(
+      expect(guest).to define_enum_for(:status).with_values(
         considered: 0,
         invited: 10,
         confirmed: 20,
@@ -16,7 +21,7 @@ RSpec.describe Guest, type: :model do
     end
   end
 
-  it { should belong_to(:group).optional }
+  it { is_expected.to belong_to(:group).optional }
 
   describe 'scopes' do
     describe '.potential' do
@@ -27,7 +32,7 @@ RSpec.describe Guest, type: :model do
         confirmed_guest = create(:guest, status: :confirmed)
         tentative_guest = create(:guest, status: :tentative)
 
-        expect(Guest.potential).to match_array([invited_guest, confirmed_guest, tentative_guest])
+        expect(described_class.potential).to contain_exactly(invited_guest, confirmed_guest, tentative_guest)
       end
     end
   end

spec/models/seat_spec.rb

@@ -1,7 +1,11 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# Copyright (C) 2024 Manuel Bustillo
+
+# frozen_string_literal: true
+
 require 'rails_helper'
 
-RSpec.describe Seat, type: :model do
+RSpec.describe Seat do
   pending "add some examples to (or delete) #{__FILE__}"
 end

spec/models/tables_arrangement_spec.rb

@@ -1,8 +1,12 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# Copyright (C) 2024 Manuel Bustillo
+
+# frozen_string_literal: true
+
 require 'rails_helper'
 
-RSpec.describe TablesArrangement, type: :model do
+RSpec.describe TablesArrangement do
   describe 'callbacks' do
     it 'assigns a name before creation' do
       expect(create(:tables_arrangement).name).to be_present

spec/models/user_spec.rb

@@ -1,7 +1,11 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# Copyright (C) 2024 Manuel Bustillo
+
+# frozen_string_literal: true
+
 require 'rails_helper'
 
-RSpec.describe User, type: :model do
+RSpec.describe User do
   pending "add some examples to (or delete) #{__FILE__}"
 end

spec/models/wedding_spec.rb

@@ -1,22 +1,27 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# Copyright (C) 2024 Manuel Bustillo
+
+# frozen_string_literal: true
+
 require 'rails_helper'
 
-RSpec.describe Wedding, type: :model do
+RSpec.describe Wedding do
   describe 'validations' do
     subject { build(:wedding) }
-    describe 'slug' do
-      it { should allow_value('foo').for(:slug) }
-      it { should allow_value('foo-bar').for(:slug) }
-      it { should allow_value('foo-123').for(:slug) }
-      it { should allow_value('foo-123-').for(:slug) }
-      it { should allow_value('foo--123').for(:slug) }
 
-      it { should_not allow_value('Foo').for(:slug) }
-      it { should_not allow_value('/foo').for(:slug) }
-      it { should_not allow_value('foo/123').for(:slug) }
-      it { should_not allow_value('foo_123').for(:slug) }
-      it { should_not allow_value('foo/').for(:slug) }
+    describe 'slug' do
+      it { is_expected.to allow_value('foo').for(:slug) }
+      it { is_expected.to allow_value('foo-bar').for(:slug) }
+      it { is_expected.to allow_value('foo-123').for(:slug) }
+      it { is_expected.to allow_value('foo-123-').for(:slug) }
+      it { is_expected.to allow_value('foo--123').for(:slug) }
+
+      it { is_expected.not_to allow_value('Foo').for(:slug) }
+      it { is_expected.not_to allow_value('/foo').for(:slug) }
+      it { is_expected.not_to allow_value('foo/123').for(:slug) }
+      it { is_expected.not_to allow_value('foo_123').for(:slug) }
+      it { is_expected.not_to allow_value('foo/').for(:slug) }
     end
   end
 end

spec/queries/expenses/total_query_spec.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 module Expenses
@@ -61,8 +63,8 @@ module Expenses
         end
 
         it 'returns the sum of fixed and variable expenses', :aggregate_failures do
-          expect(response['total_confirmed']).to eq(100 + 200 + 50 * 2)
-          expect(response['total_projected']).to eq(100 + 200 + 11 * 50)
+          expect(response['total_confirmed']).to eq(100 + 200 + (50 * 2))
+          expect(response['total_projected']).to eq(100 + 200 + (11 * 50))
           expect(response['confirmed_guests']).to eq(2)
           expect(response['projected_guests']).to eq(2 + 4 + 5)
         end

spec/queries/groups/summary_query_spec.rb

@@ -1,11 +1,13 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 module Groups
   RSpec.describe SummaryQuery do
     describe '#call' do
-      subject { described_class.new.call }
+      subject(:result) { described_class.new.call }
 
       context 'when there are no groups' do
         it { is_expected.to eq([]) }
@@ -17,7 +19,7 @@ module Groups
 
         context 'when there are no guests' do
           it 'returns the summary of groups' do
-            is_expected.to contain_exactly(
+            expect(result).to contain_exactly(
               { 'id' => parent.id,
                 'name' => 'Friends',
                 'icon' => 'icon-1',
@@ -58,11 +60,11 @@ module Groups
             create_list(:guest, 8, group: child, status: :invited)
             create_list(:guest, 9, group: child, status: :confirmed)
             create_list(:guest, 10, group: child, status: :declined)
-            create_list(:guest, 11, group: child, status: :tentative)
+            create_list(:guest, 11, group: child, status: :tentative) # rubocop:disable FactoryBot/ExcessiveCreateList
           end
 
           it 'returns the summary of groups' do
-            is_expected.to contain_exactly(
+            expect(result).to contain_exactly(
               {
                 'id' => parent.id,
                 'name' => 'Friends',

spec/rails_helper.rb

@@ -1,11 +1,13 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 # This file is copied to spec/ when you run 'rails generate rspec:install'
 require 'spec_helper'
 ENV['RAILS_ENV'] ||= 'test'
 require_relative '../config/environment'
 # Prevent database truncation if the environment is production
-abort("The Rails environment is running in production mode!") if Rails.env.production?
+abort('The Rails environment is running in production mode!') if Rails.env.production?
 require 'rspec/rails'
 # Add additional requires below this line. Rails is not loaded until this point!
 

spec/requests/affinities_spec.rb

@@ -4,7 +4,7 @@
 
 require 'swagger_helper'
 
-RSpec.describe 'affinities', type: :request do
+RSpec.describe 'affinities' do
   path '/{slug}/groups/{group_id}/affinities' do
     parameter Swagger::Schema::SLUG
     parameter name: 'group_id', in: :path, type: :string, format: :uuid, description: 'group_id'
@@ -46,7 +46,7 @@ RSpec.describe 'affinities', type: :request do
         }
       }
 
-      response_empty_200
+      response_empty200
     end
   end
 end

spec/requests/captcha_spec.rb

@@ -1,10 +1,11 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 require 'swagger_helper'
 
-RSpec.describe 'captcha', type: :request do
+RSpec.describe 'captcha' do
   path '/captcha' do
-
     post('create a CAPTCHA challenge') do
       tags 'CAPTCHA'
       consumes 'application/json'
@@ -15,7 +16,7 @@ RSpec.describe 'captcha', type: :request do
                required: %i[id],
                properties: {
                  id: { type: :string, format: :uuid },
-          media_url: { type: :string, format: :uri },
+                 media_url: { type: :string, format: :uri }
                }
         xit
       end

spec/requests/expenses_spec.rb

@@ -1,8 +1,10 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 require 'swagger_helper'
 
-RSpec.describe 'expenses', type: :request do
+RSpec.describe 'expenses' do
   path '/{slug}/expenses' do
     get('list expenses') do
       tags 'Expenses'
@@ -42,8 +44,8 @@ RSpec.describe 'expenses', type: :request do
         }
       }
 
-      response_empty_201
-      response_422
+      response_empty201
+      response422
       regular_api_responses
     end
   end
@@ -60,9 +62,9 @@ RSpec.describe 'expenses', type: :request do
         properties: Swagger::Schema::EXPENSE
       }
 
-      response_empty_200
-      response_422
-      response_404
+      response_empty200
+      response422
+      response404
       regular_api_responses
     end
 
@@ -71,8 +73,8 @@ RSpec.describe 'expenses', type: :request do
       produces 'application/json'
       parameter Swagger::Schema::SLUG
       parameter Swagger::Schema::ID
-      response_empty_200
-      response_404
+      response_empty200
+      response404
       regular_api_responses
     end
   end

spec/requests/groups_spec.rb

@@ -1,8 +1,10 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 require 'swagger_helper'
 
-RSpec.describe 'groups', type: :request do
+RSpec.describe 'groups' do
   path '/{slug}/groups' do
     get('list groups') do
       tags 'Groups'
@@ -100,7 +102,7 @@ RSpec.describe 'groups', type: :request do
         parameter Swagger::Schema::SLUG
         parameter name: :id, in: :path, type: :string, format: :uuid
 
-        response_empty_200
+        response_empty200
         regular_api_responses
       end
     end

spec/requests/guests_spec.rb

@@ -1,8 +1,10 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 require 'swagger_helper'
 
-RSpec.describe 'guests', type: :request do
+RSpec.describe 'guests' do
   path '/{slug}/guests' do
     get('list guests') do
       tags 'Guests'
@@ -51,8 +53,8 @@ RSpec.describe 'guests', type: :request do
         }
       }
 
-      response_empty_201
-      response_422
+      response_empty201
+      response422
       regular_api_responses
     end
   end
@@ -80,9 +82,9 @@ RSpec.describe 'guests', type: :request do
         }
       }
 
-      response_empty_200
-      response_422
-      response_404
+      response_empty200
+      response422
+      response404
       regular_api_responses
     end
 
@@ -92,8 +94,8 @@ RSpec.describe 'guests', type: :request do
       parameter Swagger::Schema::SLUG
       parameter name: 'id', in: :path, type: :string, format: :uuid
 
-      response_empty_200
-      response_404
+      response_empty200
+      response404
       regular_api_responses
     end
   end

spec/requests/schemas.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 module Swagger
   module Schema
     USER = {
@@ -7,13 +9,13 @@ module Swagger
       email: { type: :string, format: :email },
       created_at: SwaggerResponseHelper::TIMESTAMP,
       updated_at: SwaggerResponseHelper::TIMESTAMP
-    }
+    }.freeze
 
-    ID = {
+    ID = { # rubocop:disable Style/MutableConstant -- rswag modifies in: :path parameters
       name: 'id',
       in: :path,
       type: :string,
-      format: :uuid,
+      format: :uuid
     }
 
     GROUP = {
@@ -21,15 +23,15 @@ module Swagger
       icon: { type: :string, example: 'pi pi-crown', description: 'The CSS classes used by the icon' },
       parent_id: { type: :string, format: :uuid },
       color: { type: :string, pattern: '^#(?:[0-9a-fA-F]{3}){1,2}$' }
-    }
+    }.freeze
 
     EXPENSE = {
       name: { type: :string },
       amount: { type: :number, minimum: 0 },
       pricing_type: { type: :string, enum: Expense.pricing_types.keys }
-    }
+    }.freeze
 
-    SLUG = {
+    SLUG = { # rubocop:disable Style/MutableConstant -- rswag modifies in: :path parameters
       name: 'slug',
       in: :path,
       type: :string,
@@ -47,6 +49,6 @@ module Swagger
           answer: { type: :string }
         }
       }
-    } 
+    }.freeze
   end
 end

spec/requests/summary_spec.rb

@@ -1,8 +1,10 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 require 'swagger_helper'
 
-RSpec.describe 'summary', type: :request do
+RSpec.describe 'summary' do
   path '/{slug}/summary' do
     get('list summaries') do
       tags 'Summary'

spec/requests/tables_arrangements_spec.rb

@@ -1,8 +1,10 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 require 'swagger_helper'
 
-RSpec.describe 'tables_arrangements', type: :request do
+RSpec.describe 'tables_arrangements' do
   path '/{slug}/tables_arrangements' do
     get('list tables arrangements') do
       tags 'Tables Arrangements'

spec/requests/tokens_spec.rb

@@ -1,15 +1,5 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 require 'swagger_helper'
-
-RSpec.describe 'tokens', type: :request do
-  path '/token' do
-    get('get a cookie with CSRF token') do
-      tags 'CSRF token'
-      consumes 'application/json'
-      produces 'application/json'
-      
-      response_empty_200
-    end
-  end
-end

spec/requests/users/confirmations_spec.rb

@@ -1,9 +1,10 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 require 'swagger_helper'
 
-RSpec.describe 'users/confirmations', type: :request do
-
+RSpec.describe 'users/confirmations' do
   path '/{slug}/users/confirmation' do
     get('confirm user email') do
       tags 'Users'
@@ -17,7 +18,7 @@ RSpec.describe 'users/confirmations', type: :request do
         xit
       end
 
-      response_422
+      response422
     end
   end
 end

spec/requests/users/registrations_spec.rb

@@ -1,9 +1,10 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 require 'swagger_helper'
 
-RSpec.describe 'users/registrations', type: :request do
-
+RSpec.describe 'users/registrations' do
   path '/{slug}/users' do
     post('create registration') do
       tags 'Users Registrations'
@@ -13,7 +14,7 @@ RSpec.describe 'users/registrations', type: :request do
       parameter Swagger::Schema::SLUG
       parameter name: :body, in: :body, schema: {
         type: :object,
-        required: [:user, :wedding],
+        required: %i[user wedding],
         properties: {
           user: {
             type: :object,

spec/requests/users/sessions_spec.rb

@@ -1,11 +1,11 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 require 'swagger_helper'
 
-RSpec.describe 'users/sessions', type: :request do
-
+RSpec.describe 'users/sessions' do
   path '/{slug}/users/sign_in' do
-
     post('create session') do
       tags 'Users Sessions'
       consumes 'application/json'
@@ -32,7 +32,7 @@ RSpec.describe 'users/sessions', type: :request do
         xit
       end
 
-      response_401(message: 'Invalid Email or password.')
+      response401(message: 'Invalid Email or password.')
     end
   end
 

spec/services/tables/discomfort_calculator_spec.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 require 'rails_helper'
 module Tables
   RSpec.describe DiscomfortCalculator do
@@ -12,8 +14,7 @@ module Tables
 
     describe '#calculate' do
       before do
-        allow(calculator).to receive(:table_size_penalty).and_return(2)
-        allow(calculator).to receive(:cohesion_discomfort).and_return(3)
+        allow(calculator).to receive_messages(table_size_penalty: 2, cohesion_discomfort: 3)
       end
 
       let(:table) { Table.new(create_list(:guest, 6)) }
@@ -29,6 +30,7 @@ module Tables
         table.min_per_table = 5
         table.max_per_table = 7
       end
+
       context 'when the number of guests is in the lower bound' do
         let(:table) { Table.new(create_list(:guest, 5)) }
 
@@ -88,6 +90,7 @@ module Tables
         allow(AffinityGroupsHierarchy.instance).to receive(:distance).with(friends.id, school.id).and_return(4)
         allow(AffinityGroupsHierarchy.instance).to receive(:distance).with(work.id, school.id).and_return(5)
       end
+
       context 'when the table contains just two guests' do
         context 'when they belong to the same group' do
           let(:table) { create_list(:guest, 2, group: family) }
@@ -102,6 +105,7 @@ module Tables
               create(:guest, group: friends)
             ]
           end
+
           it { expect(calculator.send(:cohesion_discomfort)).to eq(1) }
         end
 
@@ -205,7 +209,7 @@ module Tables
         end
 
         it 'returns the sum of the penalties for each pair of guests' do
-          expect(calculator.send(:cohesion_discomfort)).to eq(4 * 1 + 4 * Rational(1, 2) + 4 * Rational(2, 3))
+          expect(calculator.send(:cohesion_discomfort)).to eq((4 * 1) + (4 * Rational(1, 2)) + (4 * Rational(2, 3)))
         end
       end
 
@@ -219,7 +223,7 @@ module Tables
         end
 
         it 'returns the sum of the penalties for each pair of guests' do
-          expect(calculator.send(:cohesion_discomfort)).to eq(6 * 1 + 2 * Rational(1, 2) + 3 * Rational(2, 3))
+          expect(calculator.send(:cohesion_discomfort)).to eq((6 * 1) + (2 * Rational(1, 2)) + (3 * Rational(2, 3)))
         end
       end
     end

spec/services/tables/distribution_spec.rb

@@ -1,23 +1,25 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 module Tables
   RSpec.describe Distribution do
     describe '#random_distribution' do
-      let(:subject) { described_class.new(min_per_table: 5, max_per_table: 10) }
+      subject(:distribution) { described_class.new(min_per_table: 5, max_per_table: 10) }
 
       context 'when there are fewer people than the minimum per table' do
         it 'creates one table' do
-          subject.random_distribution([1, 2, 3, 4])
-          expect(subject.tables.count).to eq(1)
+          distribution.random_distribution([1, 2, 3, 4])
+          expect(distribution.tables.count).to eq(1)
         end
       end
 
       context 'when there are more people than the maximum per table' do
         it 'creates multiple tables' do
-          subject.random_distribution([1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11])
-          expect(subject.tables.count).to be > 1
+          distribution.random_distribution([1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11])
+          expect(distribution.tables.count).to be > 1
         end
       end
     end

spec/services/tables/shift_spec.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 module Tables
@@ -7,7 +9,7 @@ module Tables
     describe '#each' do
       let(:shifts) do
         acc = []
-        described_class.new(initial_solution).each do |solution|
+        described_class.new(initial_solution).each do |solution| # rubocop:disable Style/MapIntoArray -- #map is not implemented
           acc << solution.tables.map(&:dup)
         end
         acc

spec/services/tables/swap_spec.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 module Tables
@@ -7,7 +9,7 @@ module Tables
     describe '#each' do
       let(:swaps) do
         acc = []
-        described_class.new(initial_solution).each do |solution|
+        described_class.new(initial_solution).each do |solution| # rubocop:disable Style/MapIntoArray -- #map is not implemented
           acc << solution.tables.map(&:dup)
         end
         acc

spec/services/vns/engine_spec.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 module VNS

spec/spec_helper.rb

@@ -1,5 +1,7 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 # This file was generated by the `rails generate rspec:install` command. Conventionally, all
 # specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
 # The generated `.rspec` file contains `--require spec_helper` which will cause
@@ -48,49 +50,47 @@ RSpec.configure do |config|
 
   # The settings below are suggested to provide a good initial experience
   # with RSpec, but feel free to customize to your heart's content.
-=begin
-  # This allows you to limit a spec run to individual examples or groups
-  # you care about by tagging them with `:focus` metadata. When nothing
-  # is tagged with `:focus`, all examples get run. RSpec also provides
-  # aliases for `it`, `describe`, and `context` that include `:focus`
-  # metadata: `fit`, `fdescribe` and `fcontext`, respectively.
-  config.filter_run_when_matching :focus
-
-  # Allows RSpec to persist some state between runs in order to support
-  # the `--only-failures` and `--next-failure` CLI options. We recommend
-  # you configure your source control system to ignore this file.
-  config.example_status_persistence_file_path = "spec/examples.txt"
-
-  # Limits the available syntax to the non-monkey patched syntax that is
-  # recommended. For more details, see:
-  # https://rspec.info/features/3-12/rspec-core/configuration/zero-monkey-patching-mode/
-  config.disable_monkey_patching!
-
-  # Many RSpec users commonly either run the entire suite or an individual
-  # file, and it's useful to allow more verbose output when running an
-  # individual spec file.
-  if config.files_to_run.one?
-    # Use the documentation formatter for detailed output,
-    # unless a formatter has already been configured
-    # (e.g. via a command-line flag).
-    config.default_formatter = "doc"
-  end
-
-  # Print the 10 slowest examples and example groups at the
-  # end of the spec run, to help surface which specs are running
-  # particularly slow.
-  config.profile_examples = 10
-
-  # Run specs in random order to surface order dependencies. If you find an
-  # order dependency and want to debug it, you can fix the order by providing
-  # the seed, which is printed after each run.
-  #     --seed 1234
-  config.order = :random
-
-  # Seed global randomization in this process using the `--seed` CLI option.
-  # Setting this allows you to use `--seed` to deterministically reproduce
-  # test failures related to randomization by passing the same `--seed` value
-  # as the one that triggered the failure.
-  Kernel.srand config.seed
-=end
+  #   # This allows you to limit a spec run to individual examples or groups
+  #   # you care about by tagging them with `:focus` metadata. When nothing
+  #   # is tagged with `:focus`, all examples get run. RSpec also provides
+  #   # aliases for `it`, `describe`, and `context` that include `:focus`
+  #   # metadata: `fit`, `fdescribe` and `fcontext`, respectively.
+  #   config.filter_run_when_matching :focus
+  #
+  #   # Allows RSpec to persist some state between runs in order to support
+  #   # the `--only-failures` and `--next-failure` CLI options. We recommend
+  #   # you configure your source control system to ignore this file.
+  #   config.example_status_persistence_file_path = "spec/examples.txt"
+  #
+  #   # Limits the available syntax to the non-monkey patched syntax that is
+  #   # recommended. For more details, see:
+  #   # https://rspec.info/features/3-12/rspec-core/configuration/zero-monkey-patching-mode/
+  #   config.disable_monkey_patching!
+  #
+  #   # Many RSpec users commonly either run the entire suite or an individual
+  #   # file, and it's useful to allow more verbose output when running an
+  #   # individual spec file.
+  #   if config.files_to_run.one?
+  #     # Use the documentation formatter for detailed output,
+  #     # unless a formatter has already been configured
+  #     # (e.g. via a command-line flag).
+  #     config.default_formatter = "doc"
+  #   end
+  #
+  #   # Print the 10 slowest examples and example groups at the
+  #   # end of the spec run, to help surface which specs are running
+  #   # particularly slow.
+  #   config.profile_examples = 10
+  #
+  #   # Run specs in random order to surface order dependencies. If you find an
+  #   # order dependency and want to debug it, you can fix the order by providing
+  #   # the seed, which is printed after each run.
+  #   #     --seed 1234
+  #   config.order = :random
+  #
+  #   # Seed global randomization in this process using the `--seed` CLI option.
+  #   # Setting this allows you to use `--seed` to deterministically reproduce
+  #   # test failures related to randomization by passing the same `--seed` value
+  #   # as the one that triggered the failure.
+  #   Kernel.srand config.seed
 end

spec/swagger_helper.rb

@@ -3,10 +3,10 @@
 # frozen_string_literal: true
 
 require 'rails_helper'
-require_relative './swagger_response_helper'
-require_relative './requests/schemas.rb'
+require_relative 'swagger_response_helper'
+require_relative 'requests/schemas'
 
-include SwaggerResponseHelper
+include SwaggerResponseHelper # rubocop:disable Style/MixinUsage
 
 RSpec.configure do |config|
   # Specify a root folder where Swagger JSON files are generated

spec/swagger_response_helper.rb

@@ -1,18 +1,19 @@
 # Copyright (C) 2024 Manuel Bustillo
 
+# frozen_string_literal: true
+
 module SwaggerResponseHelper
   TIMESTAMP_FORMAT = '\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}\.\d{3}Z'
   TIMESTAMP_EXAMPLE = Time.zone.now.iso8601(3)
 
   TIMESTAMP = { type: :string, pattern: TIMESTAMP_FORMAT, example: TIMESTAMP_EXAMPLE }.freeze
-  PASSWORD = { type: :string, minLength: User.password_length.begin, maxLength: User.password_length.end }
-
+  PASSWORD = { type: :string, minLength: User.password_length.begin, maxLength: User.password_length.end }.freeze
 
   def regular_api_responses
-    response_401
+    response401
   end
 
-  def response_422
+  def response422
     response(422, 'Validation errors in input parameters') do
       produces 'application/json'
       error_schema
@@ -20,7 +21,7 @@ module SwaggerResponseHelper
     end
   end
 
-  def response_empty_200
+  def response_empty200
     response(200, 'Success') do
       produces 'application/json'
       schema type: :object
@@ -28,7 +29,7 @@ module SwaggerResponseHelper
     end
   end
 
-  def response_empty_201
+  def response_empty201
     response(201, 'Created') do
       produces 'application/json'
       schema type: :object
@@ -36,7 +37,7 @@ module SwaggerResponseHelper
     end
   end
 
-  def response_404
+  def response404
     response(404, 'Record not found') do
       produces 'application/json'
       error_schema
@@ -44,7 +45,7 @@ module SwaggerResponseHelper
     end
   end
 
-  def response_401(message: nil)
+  def response401(message: nil)
     response(401, 'Unauthorized') do
       produces 'application/json'
       schema type: :object,