Refine endpoint to receive an affinity value and transform it into a discomfort equivalent
All checks were successful
Check usage of free licenses / check-licenses (pull_request) Successful in 49s
Add copyright notice / copyright_notice (pull_request) Successful in 1m14s
Run unit tests / unit_tests (pull_request) Successful in 3m25s

This commit is contained in:
Manuel Bustillo 2024-12-28 14:18:59 +01:00
parent 0780b17f4b
commit 5784c89b79

View File

@ -8,16 +8,16 @@ class AffinitiesController < ApplicationController
def index
overridden_affinities = @group.affinities
.each_with_object({}) { |affinity, acc| acc[affinity.another_group(@group).id] = affinity.discomfort }
Group.pluck(:id).index_with { |group_id| overridden_affinities[group_id] || GroupAffinity::NEUTRAL }
Group.where.not(id: @group.id).pluck(:id).index_with { |group_id| GroupAffinity::MAX_DISCOMFORT - (overridden_affinities[group_id] || GroupAffinity::NEUTRAL) }
.then { |affinities| render json: affinities }
end
def bulk_update
params.expect(affinities: [[:group_id, :discomfort]]).map(&:to_h).map do |affinity|
params.expect(affinities: [[:group_id, :affinity]]).map(&:to_h).map do |affinity|
{
group_a_id: @group.id,
group_b_id: affinity[:group_id],
discomfort: affinity[:discomfort]
discomfort: GroupAffinity::MAX_DISCOMFORT - affinity[:affinity]
}
end.then { |affinities| GroupAffinity.upsert_all(affinities) }
render json: {}, status: :ok
@ -25,7 +25,7 @@ class AffinitiesController < ApplicationController
rescue ActiveRecord::InvalidForeignKey
render json: { error: 'At least one of the group IDs provided does not exist.' }, status: :bad_request
rescue ActiveRecord::StatementInvalid
render json: { error: 'Invalid group ID or discomfort provided.' }
render json: { error: 'Invalid group ID or discomfort provided.' }, status: :bad_request
end
private