Refactor groups API to reuse the abstract API

This commit is contained in:
Manuel Bustillo 2024-12-09 00:48:17 +01:00
parent f01a496942
commit 0cdfccb0ca
8 changed files with 94 additions and 113 deletions

View File

@ -2,9 +2,7 @@
'use client';
import { loadGroups } from '@/app/api/groups';
import { AbstractApi, } from '@/app/api/abstract-api';
import { Group } from '@/app/lib/definitions';
import { Guest, GuestSerializer } from '@/app/lib/guest';
import { classNames } from '@/app/ui/components/button';
import GroupFormDialog from '@/app/ui/components/group-form-dialog';
@ -14,6 +12,7 @@ import SkeletonTable from '@/app/ui/guests/skeleton-row';
import GuestsTable from '@/app/ui/guests/table';
import { TabPanel, TabView } from 'primereact/tabview';
import { Suspense, useState } from 'react';
import { Group, GroupSerializer } from '@/app/lib/group';
export default function Page() {
@ -25,8 +24,8 @@ export default function Page() {
}
function refreshGroups() {
loadGroups((groups) => {
setGroups(groups);
new AbstractApi<Group>().getAll(new GroupSerializer(), (objects: Group[]) => {
setGroups(objects);
setGroupsLoaded(true);
});
}

View File

@ -1,81 +0,0 @@
/* Copyright (C) 2024 Manuel Bustillo*/
import { Group } from '@/app/lib/definitions';
import { getCsrfToken, getSlug } from '../lib/utils';
export function loadGroups(onLoad?: (groups: Group[]) => void) {
fetch(`/api/${getSlug()}/groups`)
.then((response) => response.json())
.then((data) => {
onLoad && onLoad(data.map((record: any) => {
return ({
id: record.id,
name: record.name,
color: record.color,
attendance: {
considered: record.considered,
invited: record.invited,
confirmed: record.confirmed,
tentative: record.tentative,
declined: record.declined,
total: record.total,
}
});
}));
}, (error) => {
return [];
});
}
export function updateGroup(group: Group) {
return fetch(`/api/${getSlug()}/groups/${group.id}`,
{
method: 'PUT',
body: JSON.stringify({ group: {
name: group.name,
color: group.color,
icon: group.icon,
parent_id: group.parentId
} }),
headers: {
'Content-Type': 'application/json',
'X-CSRF-TOKEN': getCsrfToken(),
}
})
.catch((error) => console.error(error));
}
export function createGroup(group: Group, onCreate?: () => void) {
fetch(`/api/${getSlug()}/groups`, {
method: 'POST',
body: JSON.stringify({
name: group.name,
color: group.color,
icon: group.icon,
parent_id: group.parentId
}),
headers: {
'Content-Type': 'application/json',
'X-CSRF-TOKEN': getCsrfToken(),
}
})
.then((response) => response.json())
.then((data) => {
onCreate && onCreate();
})
.catch((error) => console.error(error));
}
export function destroyGroup(group: Group, onDestroy?: () => void) {
fetch(`/api/${getSlug()}/groups/${group.id}`, {
method: 'DELETE',
headers: {
'X-CSRF-TOKEN': getCsrfToken(),
}
})
.then((response) => response.json())
.then((data) => {
onDestroy && onDestroy();
})
.catch((error) => console.error(error));
}

View File

@ -21,25 +21,18 @@ export type TableArrangement = {
discomfort?: number
}
export type Group = {
id?: string;
name?: string;
guest_count?: number;
icon?: string;
children?: Group[];
parentId?: string;
color?: string;
attendance?: AttendanceSummary
};
// export type Group = {
// id?: string;
// name?: string;
// guest_count?: number;
// icon?: string;
// children?: Group[];
// parentId?: string;
// color?: string;
// attendance?: AttendanceSummary
// };
export type AttendanceSummary = {
considered: number;
invited: number;
confirmed: number;
declined: number;
tentative: number;
total: number;
}
export type guestsTable = {
id: string;

62
app/lib/group.tsx Normal file
View File

@ -0,0 +1,62 @@
import { Entity } from "./definitions";
export type AttendanceSummary = {
considered: number;
invited: number;
confirmed: number;
declined: number;
tentative: number;
total: number;
}
export class Group implements Entity {
id?: string;
name?: string;
guest_count?: number;
icon?: string;
children?: Group[];
parentId?: string;
color?: string;
attendance?: AttendanceSummary
constructor(id?: string, name?: string, guest_count?: number, icon?: string, children?: Group[], parentId?: string, color?: string, attendance?: AttendanceSummary) {
this.id = id;
this.name = name;
this.guest_count = guest_count;
this.icon = icon;
this.children = children;
this.parentId = parentId;
this.color = color;
this.attendance = attendance;
}
}
export class GroupSerializer {
fromJson(data: any): Group {
return new Group(
data.id,
data.name,
data.guest_count,
data.icon,
data.children,
data.parent_id,
data.color,
data.attendance
);
}
toJson(group: Group): string {
return JSON.stringify({
group: {
name: group.name,
color: group.color,
icon: group.icon,
parent_id: group.parentId
}
});
}
apiPath(): string {
return 'groups';
}
}

View File

@ -1,10 +1,10 @@
import { Serializable } from "../api/abstract-api";
import { Entity } from "./definitions";
export const guestStatuses = ['considered', 'invited', 'confirmed', 'declined', 'tentative'] as const;
export type GuestStatus = typeof guestStatuses[number];
export class Guest {
export class Guest implements Entity {
id?: string;
name?: string;
group_name?: string;

View File

@ -2,8 +2,6 @@
'use client';
import { createGroup, updateGroup } from '@/app/api/groups';
import { Group } from '@/app/lib/definitions';
import { classNames } from '@/app/ui/components/button';
import { Dialog } from 'primereact/dialog';
import { ColorPicker } from 'primereact/colorpicker';
@ -11,6 +9,9 @@ import { Dropdown } from 'primereact/dropdown';
import { FloatLabel } from 'primereact/floatlabel';
import { InputText } from 'primereact/inputtext';
import { useState } from 'react';
import { Group, GroupSerializer } from '@/app/lib/group';
import { ApiError } from 'next/dist/server/api-utils';
import { AbstractApi } from '@/app/api/abstract-api';
export default function GroupFormDialog({groups, onCreate, onHide, group, visible }: {
groups: Group[],
@ -25,6 +26,9 @@ export default function GroupFormDialog({groups, onCreate, onHide, group, visibl
const [color, setColor] = useState<string>(group?.color || '');
const [parentId, setParentId] = useState(group?.parentId || '');
const api = new AbstractApi<Group>();
const serializer = new GroupSerializer();
function resetForm() {
setName('');
setIcon('');
@ -43,12 +47,13 @@ export default function GroupFormDialog({groups, onCreate, onHide, group, visibl
group.color = color;
group.parentId = parentId;
updateGroup(group).then(() => {
api.update(serializer, group, () => {
resetForm();
onCreate && onCreate();
});
} else {
group && createGroup({name, icon, color, parentId}, () => {
api.create(serializer, new Group(undefined, name, undefined, icon, undefined, parentId, color), () => {
resetForm();
onCreate && onCreate();
});

View File

@ -3,7 +3,7 @@
'use client';
import { AbstractApi } from '@/app/api/abstract-api';
import { Group } from '@/app/lib/definitions';
import { Group } from '@/app/lib/group';
import { Guest, GuestSerializer, GuestStatus, guestStatuses } from '@/app/lib/guest';
import { capitalize } from '@/app/lib/utils';
import { classNames } from '@/app/ui/components/button';

View File

@ -2,10 +2,10 @@
'use client';
import { Group } from '@/app/lib/definitions';
import { Group, GroupSerializer } from '@/app/lib/group';
import TableOfContents from '../components/table-of-contents';
import { PencilIcon, TrashIcon } from '@heroicons/react/24/outline';
import { destroyGroup } from '@/app/api/groups';
import { AbstractApi } from '@/app/api/abstract-api';
export default function GroupsTable({ groups, onUpdate, onEdit }: {
groups: Group[],
@ -13,6 +13,9 @@ export default function GroupsTable({ groups, onUpdate, onEdit }: {
onEdit: (group: Group) => void,
}) {
const api = new AbstractApi<Group>();
const serializer = new GroupSerializer();
return (
<TableOfContents
headers={['Name', 'Color', 'Confirmed', 'Tentative', 'Pending', 'Declined', 'Considered', 'Total', 'Actions']}
@ -46,7 +49,7 @@ export default function GroupsTable({ groups, onUpdate, onEdit }: {
</td>
<td>
<div className="flex flex-row items-center">
<TrashIcon className='size-6 cursor-pointer' onClick={() => { destroyGroup(group, () => onUpdate()) }} />
<TrashIcon className='size-6 cursor-pointer' onClick={() => { api.destroy(serializer, group, onUpdate) }} />
<PencilIcon className='size-6 cursor-pointer' onClick={() => onEdit(group)} />
</div>
</td>